-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRPC Authorization header #125
Comments
How does OAuth2 login via Grpc work? Is the procedure a standard? |
Actually nothing changes here. GRPC also acts here as transport protocol, same as HTTP. But I'm not sure that oauth is default way for GRPC (https://grpc.io/docs/guides/auth/ , for example google auth treats oauth as legacy and uses new approach ALTS). And we are currently using simple JWT, and I'm trying to implement in that way:
Our java service by default awaits metadata to contains "Authorization" header - https://github.com/yidongnan/grpc-spring-boot-starter/blob/master/grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/security/authentication/BearerAuthenticationReader.java#L76 As for httpyac - I'm not sure that it will be best way to support you internal openid/oauth tool for grpc - coz it will require an additional proto imports (need some design here) and again grpc allows to secure in different ways communication and I'm not sure that oauth2 will take same role as it did with http. Btw I'm also some kind new to GRPC =), can only say some my thoughts, but this thoughts will be not an expertise =) |
I have now removed the special handling for Authorization headers. It already felt like an error when coding, only I thought to get OAuth2 tokens in. |
Thank you! |
Hello,
Thank you againg for your great work =)!
But I have one more problem =). When using GRPC - header "Authorization" just disapearing. Can be tested with:
grpcb.in just returns response without our header. And doesn't matter if it is "Bearer" or anything else. Also want to mention that openid/oauth2 will not work here coz token also received using GRPC not via HTTP =). So i need manually to provide header.
Using event also gives nothing:
Using simple HTTP get, for example:
Works well.
Version of vscode plugin: v4.7.2
The text was updated successfully, but these errors were encountered: