Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default comment behavior incorrect in script blocks #52

Closed
gerukin opened this issue Jul 17, 2021 · 2 comments
Closed

Default comment behavior incorrect in script blocks #52

gerukin opened this issue Jul 17, 2021 · 2 comments

Comments

@gerukin
Copy link

gerukin commented Jul 17, 2021

In script blocks the editor shortcut for commenting things out behaves as if the line were http language instead of js.

Expected

{{
  // highlight me, press the keyboard shortcut to comment out -> I was just commented out
}}

Actual

{{
  # highlight me, press the keyboard shortcut to comment out -> I was just commented out as if I were http lang
}}

Syntax highlighting does work as expected however, including for comments (probably recognizes // as comment and # as itself).

@AnWeber
Copy link
Owner

AnWeber commented Jul 18, 2021

The specification of the language for each section was not yet complete. However, I was able to copy the correct specification from vetur and now it works correctly.

@AnWeber
Copy link
Owner

AnWeber commented Jul 18, 2021

I have provided an update to vscode-httpyac (v2.20.0) that fixes the bug.

@AnWeber AnWeber closed this as completed Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants