Fix #235: Update in Maestro provider to correctly parse for large integers in response #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parsing 64 bit signed integer values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens in Cardano could be minted with amounts as large as$2^{63} - 1$ (maximum of what signed 64 bit can support) which is larger than what could be safely represented for in JS. Standard JSON parser for JS would not be making use of
bigint, consequently, this PR makes use ofamounts-as-stringsheader attribute when making request to get amounts asstrings instead, to cast later asbigint.Closes spacebudz#235.