Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there are some places things could be a little faster. This PR adds some
@timeit_debug
calls fromTimerOutputs
. I've used the results from this to start on speeding things up. Here are the results after my updates:By far the most expensive operations are the "Run chains" and "Compute covariance" sections. I made the following changes:
metropolis_hastings_simple
, the original implementation was traversing across rows. In Julia, memory is organized columnwise, so it's much faster to iterate column-first. Rather than reorganize the code around this, I just swapped the indices in the function and returned the transpose.Σ_j
outside the loop. Then the loop can just update in-place. There's still a lot of overhead in this section:I'm sure this can still be reduced a lot. But rather than change too much at once, I wanted to see if you had any feedback on updatges so far.