[Feature request] Custom icon

[lifenautjoe]

Hey there,

First of all, thanks for creating this great library :-).

In my current project we have a custom IconSet, which we would like to use with this, however the implementation has the icon argument locked to being a material Icon.

Is there any chance of being able to provide a custom one?

Cheers,
Joel.

[AndreHaueisen]

@lifenautjoe Hi. Thanks man!

You can use any Icon you want. You only have to make sure to pass in the right IconData
If you need Cupertino icon for examples, you need to include cupertino_icons: ^0.1.2 dependency (make sure you run 'flutter clean' after adding the dependency) so you can use:

icon = Icon( CupertinoIcons.eye, ) // for example

Here is an example on IconData

[lifenautjoe]

Hi Andre,

Thanks for the reply!

I meant completely custom Icons, not built by the flutter team.

Could be anything arbitrary, like an Image or even a Text widget.

It's the same principle as flutter does with their buttons or navigation bars in which they allow any kind of Widget to be placed as an icon.

[AndreHaueisen]

That would require accepting a Widget instead of Icon as an argument. I'm not sure I'm comfortable with the idea. Sometimes a lot of customization can make things overly complicated. Let me make some tests and think about it a bit more.

[lifenautjoe]

Hi Andre, Thanks for your reply. Hope you can consider it. For me it’s one of the amazing things about the official flutter widgets, the incredible amount of customization possible. Cheers, Joel.

…

On Sat, 10 Nov 2018 at 13:03, Andre Haueisen ***@***.***> wrote: That would require accepting a Widget instead of Icon as an argument. I'm not sure I'm comfortable with the idea. Sometimes a lot of customization can make things overly complicated. Let me make some tests and think about it a bit more. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMJb5cM7B6BjoSgpkvD4p7qC4qmgxYI-ks5utsCHgaJpZM4YWkqb> .

[AndreHaueisen]

@lifenautjoe
Version 1.1.2 includes your request.
Thanks for your feedback.

[lifenautjoe]

Awesome ! Great job!

…

On Sat, 24 Nov 2018 at 20:57, Andre Haueisen ***@***.***> wrote: @lifenautjoe <https://github.com/lifenautjoe> Version 1.1.2 includes your request. Thanks for your feedback. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMJb5ZkNQYce_0QiNhhSbTE5nGI9BZNqks5uyaS7gaJpZM4YWkqb> .