feat(deps): update eslint-plugin-jest to latest

Fixes #183
AndreaPontrandolfo · Aug 14, 2024 · a213c03 · a213c03
1 parent 9a66082
commit a213c03
Show file tree

Hide file tree

Showing 5 changed files with 145 additions and 87 deletions.
diff --git a/apps/sheriff-webservices/package.json b/apps/sheriff-webservices/package.json
@@ -38,7 +38,7 @@
     "eslint-plugin-astro": "^1.2.3",
     "eslint-plugin-fsecond": "^1.1.1",
     "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jest": "^27.2.1",
+    "eslint-plugin-jest": "^28.8.0",
     "eslint-plugin-jsdoc": "^48.11.0",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-lodash-f": "^7.5.3",

diff --git a/packages/eslint-config-sheriff/package.json b/packages/eslint-config-sheriff/package.json
@@ -67,7 +67,7 @@
     "eslint-plugin-astro": "^1.2.3",
     "eslint-plugin-fsecond": "^1.1.1",
     "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jest": "^27.2.1",
+    "eslint-plugin-jest": "^28.8.0",
     "eslint-plugin-jsdoc": "^48.11.0",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-lodash-f": "^7.5.3",

diff --git a/packages/eslint-config-sheriff/src/getExportableConfig.ts b/packages/eslint-config-sheriff/src/getExportableConfig.ts
@@ -40,7 +40,7 @@ export const getExportableConfig = (
 
   if (userConfigChoices.jest) {
     exportableConfig.push(
-      getJestConfig(userConfigChoices.pathsOverrides?.tests),
+      ...getJestConfig(userConfigChoices.pathsOverrides?.tests),
     );
   }
 

diff --git a/packages/eslint-config-sheriff/src/getJestConfig.ts b/packages/eslint-config-sheriff/src/getJestConfig.ts
@@ -1,24 +1,20 @@
 import jest from 'eslint-plugin-jest';
+import tseslint from 'typescript-eslint';
 import { allJsExtensions } from '@sherifforg/constants';
 import { jestHandPickedRules } from './handpickedRules/jestHandPickedRules';
 
 export const getJestConfig = (pathsOverrides?: string[]) => {
-  return {
+  return tseslint.config({
     files: pathsOverrides ?? [
       `**/*.{test,spec}.{${allJsExtensions}}`,
       `**/tests/**/*.{${allJsExtensions}}`,
       `**/__tests__/**/*.{${allJsExtensions}}`,
     ],
-    plugins: {
-      jest,
-    },
-    languageOptions: {
-      globals: jest.environments.globals.globals,
-    },
+    extends: jest.configs['flat/style'],
+    // @ts-expect-error
     rules: {
-      ...jest.configs.style.rules,
       ...jestHandPickedRules,
-      '@typescript-eslint/unbound-method': 0, // see reference: https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/unbound-method.md
+      '@typescript-eslint/unbound-method': 0,
     },
-  };
+  });
 };