Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored entity serialization #163

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

AndreasLrx
Copy link
Owner

Description

Rework of entity serialization with explicit type registration using a macro.

Close #150 (again)

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

[optional] Minor fixes

Fix Registry.getSystem: It was looking in the storages instances instead of the system instances

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx added enhancement New feature or request entity Related to ecstasy entities serialization labels Oct 10, 2024
@AndreasLrx AndreasLrx added this to the ECS Serialization milestone Oct 10, 2024
@AndreasLrx AndreasLrx self-assigned this Oct 10, 2024
@AndreasLrx AndreasLrx force-pushed the feature/150-entity-serialization branch from 69cd5ca to 3f69a46 Compare October 10, 2024 07:59
@AndreasLrx AndreasLrx force-pushed the feature/150-entity-serialization branch from 3f69a46 to 3f96a79 Compare October 10, 2024 08:38
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.59%. Comparing base (cfc7649) to head (3f96a79).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   82.23%   82.59%   +0.36%     
==========================================
  Files          64       64              
  Lines        1103     1103              
  Branches      353      353              
==========================================
+ Hits          907      911       +4     
+ Misses        140      135       -5     
- Partials       56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasLrx AndreasLrx merged commit 90fe105 into main Oct 10, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the feature/150-entity-serialization branch October 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request entity Related to ecstasy entities serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(De)Serialize an Entity with user defined serialization method
2 participants