Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function specifiers #172

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Conversation

AndreasLrx
Copy link
Owner

Description

Huge refactoring to add missing [[nodiscard]], [[maybe_unused]], 'noexcept, [[(un)likely]]` and some documentations.

Close #171

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

[optional] Minor fixes

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx added documentation Improvements or additions to documentation refactor Code rework labels Oct 18, 2024
@AndreasLrx AndreasLrx self-assigned this Oct 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 69.76744% with 52 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (d245348) to head (4354a3c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/util/serialization/toml/TomlNode.hpp 33.33% 8 Missing ⚠️
src/ecstasy/integrations/event/inputs/Gamepad.hpp 50.00% 4 Missing and 2 partials ⚠️
src/ecstasy/integrations/event/events/Event.hpp 0.00% 4 Missing ⚠️
src/ecstasy/integrations/event/inputs/Keyboard.hpp 42.85% 3 Missing and 1 partial ⚠️
src/ecstasy/integrations/event/inputs/Mouse.hpp 50.00% 2 Missing and 1 partial ⚠️
src/ecstasy/storages/MapStorage.hpp 25.00% 3 Missing ⚠️
src/ecstasy/registry/Registry.hpp 60.00% 2 Missing ⚠️
src/ecstasy/storages/Instances.hpp 50.00% 0 Missing and 2 partials ⚠️
src/util/serialization/toml/TomlArrayNode.cpp 84.61% 2 Missing ⚠️
src/util/serialization/toml/TomlObjectNode.cpp 85.71% 2 Missing ⚠️
... and 16 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   82.59%   81.93%   -0.67%     
==========================================
  Files          64       64              
  Lines        1103     1129      +26     
  Branches      353      352       -1     
==========================================
+ Hits          911      925      +14     
- Misses        135      144       +9     
- Partials       57       60       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasLrx AndreasLrx force-pushed the refactor/171-missing-specifiers branch 2 times, most recently from c16eb10 to 3dfd85a Compare October 18, 2024 09:39
@AndreasLrx AndreasLrx force-pushed the refactor/171-missing-specifiers branch from 3dfd85a to 4354a3c Compare October 18, 2024 09:44
@AndreasLrx AndreasLrx merged commit 2706640 into main Oct 18, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the refactor/171-missing-specifiers branch October 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor Code rework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REF] Ensure the [[nodiscard]], [[maybe_unused]] or any other specifiers are used when possible
2 participants