Swift 4 #2
Closed
Swift 4 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiled with xcode 9.1
The `textBoundingBox` is the rectangle that is needed to display the full attributed text in the cell and has the right dimensions, but the point is relative to the `frame` coordinates so the `point` is never contained in the in the `textBoundingBox` because *it represents the size of the text in the label, **but not the position of the text in the label**.* So this code is giving false negative checks
|
any comment @ProjectDent ? i need your input regarding the todos :) |
oliviertouron-playster
approved these changes
Nov 25, 2017
|
TouchGestureRecognizer is not correct for Swift 4 |
|
hi @oliviertouron-playster sorry for taking so long to come back. But what's the issue with |
|
Thanks @fespinoza ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've converted the project to swift 4
this also closes #1
As I explained in c5f1c0b I slightly changed the behavior of the pod