mark all internal properties as non-enumerable (close DevExpress#1182, …

…DevExpress#1209) (DevExpress#1206)

* mark all internal properties as non-enumerable (close DevExpress#1182)

* fix tests

src/client/sandbox/event/listening-context.js

@@ -35,7 +35,7 @@ export function addListeningElement (el, events) {
     }
 
     if (!isElementListening(el))
-        el[ELEMENT_LISTENING_EVENTS_STORAGE_PROP] = elementCtx;
+        Object.defineProperty(el, ELEMENT_LISTENING_EVENTS_STORAGE_PROP, { value: elementCtx, writable: true });
 }
 
 export function removeListeningElement (el) {

src/client/sandbox/node/index.js

@@ -49,7 +49,10 @@ export default class NodeSandbox extends SandboxBase {
                 urlAttrName = el.hasAttribute(urlAttrName) ? urlAttrName : null;
             }
 
-            el[INTERNAL_PROPS.processedContext] = this.window;
+            Object.defineProperty(el, INTERNAL_PROPS.processedContext, {
+                value:    this.window,
+                writable: true
+            });
 
             // NOTE: We need to reprocess url attribute of element, if it's moved to different window (GH-564)
             if (urlAttrName)

src/client/sandbox/windows-storage.js

@@ -7,8 +7,8 @@ function getStorage () {
     let storage               = topSameDomainWindow[WINDOWS_STORAGE];
 
     if (!storage) {
-        storage                              = [];
-        topSameDomainWindow[WINDOWS_STORAGE] = storage;
+        storage = [];
+        Object.defineProperty(topSameDomainWindow, WINDOWS_STORAGE, { value: storage });
     }
 
     return storage;

src/client/utils/url-resolver.js

@@ -22,7 +22,7 @@ export default {
         // we will use native methods from an actual document.
         // However, a document that contains an element for url resolving is created using a previous version of nativeMethods.
         if (!doc[DOCUMENT_URL_RESOLVER])
-            doc[DOCUMENT_URL_RESOLVER] = this._createResolver(doc);
+            Object.defineProperty(doc, DOCUMENT_URL_RESOLVER, { value: this._createResolver(doc), writable: true });
 
         return doc[DOCUMENT_URL_RESOLVER];
     },
@@ -83,7 +83,7 @@ export default {
     },
 
     changeUrlPart (url, prop, value, doc) {
-        const resolver  = this.getResolverElement(doc);
+        const resolver = this.getResolverElement(doc);
 
         resolver.href  = url;
         resolver[prop] = value;

test/client/fixtures/api-test.js

@@ -12,8 +12,8 @@ QUnit.testDone(function () {
 module('regression');
 
 asyncTest('should prevent navigation from the about:blank page to the relative url (GH-645)', function () {
-    var iframe   = document.createElement('iframe');
-    var handler  = function () {
+    var iframe  = document.createElement('iframe');
+    var handler = function () {
         var iframeHammerhead = iframe.contentWindow['%hammerhead%'];
         var timeoutId        = null;
         var finalize         = function () {

test/client/fixtures/common-test.js

@@ -0,0 +1,31 @@
+test('mark all internal properties as non-enumerable (GH-1182)', function () {
+    var documentEnumerableProperties  = Object.keys(document);
+    var windowEnumerableProperties    = Object.keys(window);
+    var elementEnumerableProperties   = Object.keys(document.body);
+    var hasEnumerableInternalProperty = function (propName) {
+        // Used for tests
+        if (propName === 'hammerhead')
+            return false;
+
+        return propName.indexOf('hammerhead') !== -1;
+    };
+
+    for (var i = 0; i < documentEnumerableProperties.length; i++) {
+        var documentEnumerableProperty = documentEnumerableProperties[i];
+
+        ok(!hasEnumerableInternalProperty(documentEnumerableProperty), documentEnumerableProperty);
+    }
+
+    for (var j = 0; j < windowEnumerableProperties.length; j++) {
+        var windowEnumerableProperty = windowEnumerableProperties[j];
+
+        ok(!hasEnumerableInternalProperty(windowEnumerableProperty), windowEnumerableProperty);
+    }
+
+    for (var k = 0; k < elementEnumerableProperties.length; k++) {
+        var elementEnumerableProperty = elementEnumerableProperties[k];
+
+        ok(!hasEnumerableInternalProperty(elementEnumerableProperty), elementEnumerableProperty);
+    }
+});
+