fix(logsender): do not log SocktException when manually closing LogSe…

…nderHandler (#1183)
AndroidIDEOfficial · Aug 7, 2023 · 4d8a6a2 · 4d8a6a2
1 parent ce1ab73
commit 4d8a6a2
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/app/src/main/java/com/itsaky/androidide/services/log/LogSenderHandler.kt b/app/src/main/java/com/itsaky/androidide/services/log/LogSenderHandler.kt
@@ -35,6 +35,7 @@ class LogSenderHandler(
   internal var onClose: (String) -> Unit = {}
 ) : Thread("LogSenderHandler"), AutoCloseable {
 
+  private var manuallyClosed = false
   private val log = ILogger.newInstance("LogSenderHandler")
 
   override fun run() {
@@ -45,18 +46,24 @@ class LogSenderHandler(
             LogLine.forLogString(reader.readLine())?.let { line -> consumer?.invoke(line) }
           } catch (interrupt: InterruptedException) {
             currentThread().interrupt()
+            break
           }
         }
       }
     } catch (err: SocketException) {
-      log.error("An error occurred while reading from socket", err)
+      log.error("An error occurred while reading from socket")
+      if (!manuallyClosed) {
+        log.error(err)
+      }
     } finally {
       close()
     }
   }
 
   override fun close() {
     try {
+      manuallyClosed = true
+
       if (!socket.isClosed) {
         log.debug("Closing log sender handler...")
         socket.close()