Add support for bigger than expected response sizes #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is based on Finnish E-ID card spec (FINEID S1) Chapter 3.3. I don't have access to the actual ISO 7816 spec, but the above document cites it as normative source. If my understanding is correct, the spec calls for to use GET RESPONSE (INS 0xC0) to read a command response in cases where the response length is unknown or greater than 256. I do not have a list of commands which may have unknown length, so the implementation here reads while commands response sw1 indicates more data available (i.e. while sw1 == 0x61). This works at least with the sample Finnish E-ID documents at my disposal. |
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #174