Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read/Write of styles gap and grid-gap swap the order of col and row #137

Closed
danielhazel opened this issue Mar 27, 2023 · 2 comments
Closed

Read/Write of styles gap and grid-gap swap the order of col and row #137

danielhazel opened this issue Mar 27, 2023 · 2 comments
Labels
bug
Milestone
v1.0

Comments

@danielhazel
Copy link

Bug Report

Description

A style read as:

grid-gap: 10px 80px;

is written as:

grid-gap: 80px 10px;

Similarly, a style read as:

gap: 10px 80px;

is written as:

gap: 80px 10px;

Possible Solution

row and col are incorrectly assigned here:

https://github.com/AngleSharp/AngleSharp.Css/blob/main/src/AngleSharp.Css/Declarations/GridGapDeclaration.cs#L33

and here:

https://github.com/AngleSharp/AngleSharp.Css/blob/main/src/AngleSharp.Css/Declarations/GapDeclaration.cs#L33
@FlorianRappl
Copy link
Contributor

PR welcome.

@FlorianRappl FlorianRappl added this to the v1.0 milestone Jun 14, 2023
@FlorianRappl
Copy link
Contributor

Implemented and ready for the next preview / 1.0.0.

FlorianRappl added a commit that referenced this issue Jun 14, 2023
@FlorianRappl
Fixed grid and grid-gap ordering #137
12f61a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@FlorianRappl @danielhazel