Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure case using Union #381

Closed
brianwinterpixel opened this issue Jan 26, 2023 · 2 comments
Closed

Failure case using Union #381

brianwinterpixel opened this issue Jan 26, 2023 · 2 comments

Comments

@brianwinterpixel
Copy link

Found this while using commit 09c531c

PathsD paths;
PathD v1;
v1.push_back(PointD(0, 0));
v1.push_back(PointD(20, 10));
v1.push_back(PointD(0, 10));
paths.push_back(v1);
PathD v2;
v2.push_back(PointD(10, 0));
v2.push_back(PointD(20, 10));
v2.push_back(PointD(10, 10));
paths.push_back(v2);

PathsD solution = Union(paths, FillRule::NonZero);

image

When mirrored vertically, Union produces the correct output.
@AngusJohnson
Copy link
Owner

Thanks again Brian. I've verified this bug and will have a fix uploaded shortly (today).

AngusJohnson added a commit that referenced this issue Jan 27, 2023
@AngusJohnson
Fixed significant bug in non-horizontal polygon merging (#381)
3742404 
Fixed wrong version no. in CMake (#380)
@AngusJohnson
Copy link
Owner

Hopefully fixed now.

AngusJohnson added a commit that referenced this issue Jan 31, 2023
@AngusJohnson
improved exception handling C++ (#382)
9c26d55 
minor improvements to polygon merging (#381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AngusJohnson @brianwinterpixel