Shared library fix

[sergey-239]

Angus, @lederernc, @reunanen and @damiandixon.

Please review this revised shared_library patch.
Please verify that VS project generation and using as a git submodule performs as expected.

Thank you,
Sergey

[sergey-239]

FYI, build & tests for Fedora in a mock are successful (see attached log)
build.log

[AngusJohnson]

Looking very good Sergey. Thanks!
Just a few warnings when compiling in VS 2022 ...

Severity	Code	Description	Project	File	Line	Suppression State
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cl	1	
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cl	1	
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cl	1	
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cl	1	


Severity	Code	Description	Project	File	Line	Suppression State
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cl	1	
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cl	1	
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cl	1	
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Release\cl	1	

and in the sample apps, perhaps the following is simpler ...
#include "clipper2/clipper.h"
instead of
#include "../../Clipper2Lib/include/clipper2/clipper.h"

[sergey-239]

Looking very good Sergey. Thanks! Just a few warnings when compiling in VS 2022 ...

Severity	Code	Description	Project	File	Line	Suppression State
Warning	D9025	overriding '/W3' with '/W4'	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cpp	C:\Users\awj19\Documents\Dev\Clipper2\cpp\out\build\x64-Debug\cl	1	

These overrides originally were in CMakeLists.txt, I did not touch these

and in the sample apps, perhaps the following is simpler ... #include "clipper2/clipper.h" instead of #include "../../Clipper2Lib/include/clipper2/clipper.h"

The relative paths were used previously. I leaved them relative to make github workflow happy as we did not discuss this. Of course it's better to use "clipper2/clipper.h" here as the affected files are Examples. I will add a commit to fix this.

[AngusJohnson]

Sergey. Looks good to me and is passing CI testing.
I'm happy if you want to merge this now.

[sergey-239]

Sergey. Looks good to me and is passing CI testing. I'm happy if you want to merge this now.

Angus, I would prefer it first verified that VS project generation is functioning (I have no windows so I cant test the changes myself)

Thank you
Sergey.

[AngusJohnson]

Angus, I would prefer it first verified that VS project generation is functioning.

I've just tested this with VS 2022 and everything compiles and runs without any problems.

[sergey-239]

Angus, I would prefer it first verified that VS project generation is functioning.

I've just tested this with VS 2022 and everything compiles and runs without any problems.

Then it is OK with me, I did everything I planned in order to package.
It would be nice if you bump a version after merge if there is no blockers for this as the patch list after 1.0.4 is quite long now.

[AngusJohnson]

It would be nice if you bump a version after merge if there is no blockers for this as the patch list after 1.0.4 is quite long now.

I will do very soon.
However, there are a couple of other things that I need to do first.
I was thinking of including a fast rectangular clipper (just finished), but perhaps that should be to start the next versioning.

[sergey-239]

I will do very soon. However, there are a couple of other things that I need to do first. I was thinking of including a fast rectangular clipper (just finished), but perhaps that should be to start the next versioning.

not a problem, you are the boss:)

[AngusJohnson]

you are the boss:)

((( ・o・ ))) ~ my head is swelling 😱.