Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken windows compatibility since upgrade to globby@v11 #156

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Fixes broken windows compatibility since upgrade to globby@v11 #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa568d7
Fix lint and format script on windows
curvedriver Feb 24, 2022
54e90a6
Fix broken windows compatibility
curvedriver Feb 24, 2022
eb106b7
Remove unexpected trailing comma
curvedriver Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"lodash": "^4.17.21",
"meow": "^9.0.0",
"minimist": "^1.2.5",
"normalize-path": "^3.0.0",
"semver-compare": "^1.0.0"
},
"devDependencies": {
Expand All @@ -49,8 +50,8 @@
"test": "jest --verbose --runInBand",
"release": "node-publisher release",
"ci": "npm run lint && npm test",
"lint": "eslint 'src/**/*.js' && prettier --check 'src/**/*.js'",
"format": "./node_modules/.bin/prettier --write 'src/**/*.js'",
"lint": "eslint src/**/*.js && prettier --check src/**/*.js",
"format": "prettier --write src/**/*.js",
"lint-staged": "lint-staged"
},
"keywords": [
Expand Down
5 changes: 4 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const uniq = require("lodash/uniq");
const orderBy = require("lodash/orderBy");
const globby = require("globby");
const perf = require("execution-time")();
const normalize = require("normalize-path");

const runCommand = require("./utils/runCommand");
const fileExists = require("./utils/fileExists");
Expand Down Expand Up @@ -86,7 +87,9 @@ module.exports = async ({ input, flags }) => {
: packagesConfig;

const packagesRead = await globby(
defaultPackagesGlobs.map(glob => resolve(projectDir, glob, "package.json")),
defaultPackagesGlobs.map(glob => {
return normalize(resolve(projectDir, glob, "package.json"));
}),
{ expandDirectories: true }
);

Expand Down