Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counting/Selected Buildings Police and Fire Stations #105

Closed
StingMcRay opened this issue Jun 2, 2019 · 6 comments · Fixed by #356
Closed

Counting/Selected Buildings Police and Fire Stations #105

StingMcRay opened this issue Jun 2, 2019 · 6 comments · Fixed by #356

Comments

@StingMcRay
Copy link
Contributor

StingMcRay commented Jun 2, 2019

The Police Station and the Fire Station are marked as 'Unknown Building' when selected,
and thus will not showed in the building statics (not selected)
This is only affecting the New world Police and Fire Station

@StingMcRay
Copy link
Contributor Author

StingMcRay commented Jun 2, 2019

Seams only affecting the Police Station, Chapel and Hospital (New World)
afbeelding

@FroggieFrog
Copy link
Collaborator

I will look into it.

@StingMcRay
Copy link
Contributor Author

Yeah if you like to : my treatment is tomorrow so i can't type for a couple of days

@FroggieFrog
Copy link
Collaborator

I found the issue, but I haven't figured out why this code is present.
In the screenshot you see the relevant code and the issue as datatip.
Why is there a search via IconfileName? Why not just use the icon? There is no resizing of an icon as I can see.

wrong_identifier

@StingMcRay
Copy link
Contributor Author

I made this code that users when they create an own object that this will seen as 'Unknown Object' as this is not present in the preset list: i checked via IconName but then i think its something like I see the first (old world one) and that is not it, so it is unknown

@FroggieFrog
Copy link
Collaborator

This is also the root cause of another issue:
If you place the Cattle Farm - (6) from Obreros it should have the Identifier Agriculture_colony01_09 (Cattle Farm) but after line 517 it has Identifier Agriculture_02 (Cattle Farm).
This is causing problems in the FandomTemplateExporter because now it is a completly different building (Old World vs New World).

So I would suggest to remove this functionality completly for now till issue #106 is solved.

@FroggieFrog FroggieFrog linked a pull request Sep 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants