Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict differentiation of predefined and custom buildings #106

Open
FroggieFrog opened this issue Jun 3, 2019 · 3 comments
Open

Strict differentiation of predefined and custom buildings #106

FroggieFrog opened this issue Jun 3, 2019 · 3 comments

Comments

@FroggieFrog
Copy link
Collaborator

This issue emerged after a private discussion with @StingMcRay on discord according to issue #105.

We came to the conclusion that there is a need for a strict(er) differentiation of buildings from the presets file and custom buildings created by the user that are not in the presets file.

The intention of the logic used in issue #105 was to check if a building with the same settings that the user made (icon and size) is found in the presets file and "map" the custom building to a predefined one.
This is somewhat hacky and not very transparent to the user.

So the following idea emerged:
If a building from the presets file is selected (via TreeView) then there will be a green border around the building settings.
If the user "created" a custom building then there will be an orange border.
Maybe a checkbox or something where the user "accepts" the automatic conversion.

The use of different borders would make it more transparent to the user that the building configuration is not in the presets file.
Also to avoid countless "Unknown Building" entries in the statistics the label entered by the user could be used.

This is a quick mockup:
unknown

So the next thing is to define which setting should be used to find a building in the presets file.
Continue to use the current logic of same icon and same size (rotation doesn't matter) or use some other logic?

Please share your opinions! It is an open discusison.

@StingMcRay
Copy link
Contributor

StingMcRay commented Sep 14, 2021

This Issue was addressed in Anno Designer version 9 i believe, however it is not mentioned, but will fixed now in PR #356
The only way an "Unknown Object" in statistics screen is showed, if the user make a building at start and not name it on the label text box.
Name change can be done, on known buildings and own creation without selected a preset tree building, as long users fill in the Label, however those buildings will never be translated for others, as they are not part of the preset list.

As it comes to Check same size of buildings with the same icon, as we made it possible to have users creating there own buildings, this is not possible now, unless we make an option that user need to set so the program will check icon/size etc

@FroggieFrog
Copy link
Collaborator Author

The root problem for opening this issue might be solved, but the idea of this PR is still not solved.

Currently (and also after PR #356) there is no way for a user to know if a building is from the presets or a custom building.

@StingMcRay
Copy link
Contributor

I know, we need to dive in deeper in this matter... i have some ideas but need to work that out on my mind first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants