Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check identifier for uniqueness #133

Closed
FroggieFrog opened this issue Jul 5, 2019 · 6 comments · Fixed by #357
Closed

check identifier for uniqueness #133

FroggieFrog opened this issue Jul 5, 2019 · 6 comments · Fixed by #357
Labels
PresetParser Features or issues relationg to the PresetParser.

Comments

@FroggieFrog
Copy link
Collaborator

Add a check against all presets to make sure the identifier is unique.
@FroggieFrog FroggieFrog added the PresetParser Features or issues relationg to the PresetParser. label Jul 5, 2019
@StingMcRay
Copy link
Contributor

PR #356 will remove this

@FroggieFrog
Copy link
Collaborator Author

No it will not, because there is no check/validation in the PresetParser.

@StingMcRay
Copy link
Contributor

My bad... i need to look into that yet

@FroggieFrog
Copy link
Collaborator Author

I can add a validator for you.
In my mind it would be run at the very end of the preset creation and check for duplicate identifiers.

@StingMcRay
Copy link
Contributor

i have some name checking already
afbeelding

and on they end it will be added
afbeelding

I can (or you can) do the same on Identifiers (but this is going for each anno, separated, as each anno can have the same name or even en identifier so...)

@StingMcRay
Copy link
Contributor

It seams to be missing in anno 1800...

@FroggieFrog FroggieFrog mentioned this issue Sep 14, 2021
Merged
FroggieFrog added a commit that referenced this issue Sep 15, 2021
@FroggieFrog @StingMcRay
Fix #133: check for duplicate identifiers in PresetParser (#357)
0c3dcb1 
* add check for unique identifiers
* add simple tests for validator
* add option to validate an exisiting file
* support list of known duplicates when validating
* updated `presets.json` because of removed duplicate identifiers

Co-authored-by: Sting Mcray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PresetParser Features or issues relationg to the PresetParser.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #133: check for duplicate identifiers in PresetParser FroggieFrog/anno-designer
2 participants
@FroggieFrog @StingMcRay