Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide app.config in explorer (fix #160) #412

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

FroggieFrog
Copy link
Collaborator

This PR sets the Hidden attribute to the app.config file and uses 7zip to create the zip file for release.
The build in (in cake) zip functionality does not respect the file attributes, but 7zip does.
The created zip file can still be extracted with the explorer.
This should fix #160.

- use 7zip to create zip-file
@FroggieFrog FroggieFrog added this to the Anno Designer 9.3 Release milestone Jun 17, 2022
@FroggieFrog FroggieFrog requested a review from StingMcRay June 17, 2022 11:05
@StingMcRay
Copy link
Contributor

Is it mend to be that the "Read only" Attribute is removed from the file?

The Hidden File Attribute is working as intended

@StingMcRay
Copy link
Contributor

Never mind the Read Only Attribute... i had an other file selected seams...

Copy link
Contributor

@StingMcRay StingMcRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended : Hidden File Attribute was nice set to the file "AnnoDesigner.exe.config"

@FroggieFrog
Copy link
Collaborator Author

There should never be a read only flag at the app.config. At least the log level could be configured with it.

@StingMcRay
Copy link
Contributor

There should never be a read only flag at the app.config. At least the log level could be configured with it.

I know, thats why i said never mind... seams i had an other file selected back when i check the older version :D

@FroggieFrog FroggieFrog merged commit aae9349 into AnnoDesigner:master Jun 17, 2022
@FroggieFrog FroggieFrog deleted the hide-app-config branch June 17, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnnoDesigner.exe vs AnnoDesigner.exe.config
2 participants