Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TitleId to TitlePlayerAccount Entity and loads its on creation … #60

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Added TitleId to TitlePlayerAccount Entity and loads its on creation … #60

merged 2 commits into from
Feb 14, 2022

Conversation

Annonator
Copy link
Owner

…to Fix #56

@Annonator Annonator requested a review from Structed February 13, 2022 13:37
Structed
Structed requested changes Feb 13, 2022
View reviewed changes
Copy link
Collaborator

@Structed Structed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think teh change in semantics is not correct. Please check.
Otherwise, looks good

@Annonator Annonator requested a review from Structed February 14, 2022 06:17
@Annonator
Copy link
Owner Author

I think teh change in semantics is not correct. Please check. Otherwise, looks good

Reverted back to intial semantics and merged it :). thanks for the review!

@Annonator Annonator merged commit 1781e98 into main Feb 14, 2022
@Annonator Annonator deleted the 56-Integrate-TitleListEntity-into-PlayerAccountEntity branch February 14, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Structed Structed Awaiting requested review from Structed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate PlayedTitleListEntity into a PlayerAccountEntity
2 participants
@Annonator @Structed