feature/nsis installer update and new external lib build dir #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 14, 2020 16:07
Update CMakeList so dependencies are build in src/build_deps directory
jmkerloch
commented
Sep 2, 2020
jmkerloch
commented
Sep 2, 2020
jmkerloch
changed the title
sgatto
reviewed
Sep 2, 2020
| @@ -169,8 +169,8 @@ macro(DBG_MSG _MSG) | |||
| "${CMAKE_CURRENT_LIST_FILE}(${CMAKE_CURRENT_LIST_LINE}): ${_MSG}") | |||
There was a problem hiding this comment.
Question : this file is processed by cmake only in case of vcpkg use. Why ? (I don't understand the comment in src/CMakeLists.txt : 227)
There was a problem hiding this comment.
This file is use as a patch for vcpkg because there is currently an issue with find_package(wxWidgets) with vcpkg.
See microsoft/vcpkg#4756
There is a PR waiting for review that will maybe remove the need of this specific .cmake.
…st above source directory. Use of checkout instead of --set-branch from git submodule
guilpier-code
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update NSIS installer for examples and sources packaging.
Use of new github repository to fetch examples.
Use of new external library build dir to allow multiple build directory with common external library build dir.
Add windows system librairies to NSIS installer
Correction of documentation name for NSIS installer