Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extended_asset missing operators #105

Closed
YaroShkvorets opened this issue Feb 15, 2023 · 0 comments · Fixed by #117
Closed

extended_asset missing operators #105

YaroShkvorets opened this issue Feb 15, 2023 · 0 comments · Fixed by #117
Assignees
@ScottBailey
Labels
enhancement New feature or request 👍 lgtm test-refinement

Comments

@YaroShkvorets
Copy link
Contributor

YaroShkvorets commented Feb 15, 2023 •
edited
Loading

Inexplicably, some operators are missing for extended_asset class.
I.e. < is there, but > is not.
+= is there but *= is not, etc

All in all, the following are not there (but exist for asset):

  • Greater than >
  • Division assignment with a number /= int64_t
  • Multiplication assignment with a number *= int64_t
  • Multiplication with a number preceeding int64_t *
  • Multiplication with a number proceeding * int64_t
  • Division with a number / int64_t
  • Division with another extended_asset / extended_asset

I can submit a PR for these if required.
@stephenpdeos stephenpdeos added 👍 lgtm enhancement New feature or request and removed triage labels Mar 2, 2023
@ScottBailey ScottBailey self-assigned this Mar 21, 2023
@ScottBailey ScottBailey moved this from Todo to In Progress in Team Backlog Mar 21, 2023
@ScottBailey ScottBailey mentioned this issue Mar 22, 2023
Merged
2 tasks
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Mar 23, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottBailey ScottBailey

Labels
enhancement New feature or request 👍 lgtm test-refinement
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add extended_asset operators and unit tests. AntelopeIO/cdt
4 participants
@ScottBailey @YaroShkvorets @stephenpdeos @enf-ci-bot