Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] fix duplicate definition of capi_checksum256 #30

Merged
merged 1 commit into from
Sep 7, 2022
Merged

[3.0] fix duplicate definition of capi_checksum256 #30

merged 1 commit into from
Sep 7, 2022

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Sep 7, 2022

Change Description

crypto_ext.hpp defines capi_checksum256 for internal use. Unfortunately this conflicts with capi_checksum256 in system.hpp. The fix is to rename capi_checksum256 to capi_checksum256_ext in crypto_ext.hpp.

Resolve #29

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@linh2931 linh2931 requested a review from larryk85 September 7, 2022 14:10
@linh2931 linh2931 merged commit 9e9a089 into release/3.0 Sep 7, 2022
@linh2931 linh2931 deleted the capi_checksum256_fix branch September 7, 2022 17:11
@linh2931 linh2931 mentioned this pull request Sep 7, 2022
Merged
2 tasks
@stephenpdeos stephenpdeos added this to the CDT 3.0.0 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryk85 larryk85 larryk85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CDT 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@linh2931 @larryk85 @stephenpdeos