Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

different signedness comparison warnings #1053

Closed
linh2931 opened this issue Apr 19, 2023 · 1 comment · Fixed by #1061
Closed

different signedness comparison warnings #1053

linh2931 opened this issue Apr 19, 2023 · 1 comment · Fixed by #1061
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Leap v5.0.0-rc1

Comments

@linh2931
Copy link
Member

Leap on Main branch compiles very clean on Ubuntu 20.02, with only two types and 27 instances of warnings. 26 of them are

/home/lh/work/leap-main/libraries/chainbase/include/chainbase/undo_index.hpp:524:23:    warning: comparison of integer expressions of different signedness: ‘uint64_t’ {aka ‘long unsigned int’} and ‘long int’ [-Wsign-compare]
  524 |          if( revision > std::numeric_limits<int64_t>::max() )
      |              ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixing it will give us an almost clean build.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Apr 19, 2023
@linh2931 linh2931 self-assigned this Apr 19, 2023
@BenjaminGormanPMP
Copy link

New issue added @stephenpdeos.

@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Apr 19, 2023
@stephenpdeos stephenpdeos modified the milestone: Leap 4.0.0 Apr 19, 2023
@linh2931 linh2931 removed the triage label Apr 20, 2023
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Apr 20, 2023
@linh2931 linh2931 mentioned this issue Apr 20, 2023
Merged
@bhazzard bhazzard added this to the Leap v5.0.0-rc1 milestone Apr 20, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Update chainbase to include comparison of different signedness warning fix AntelopeIO/leap
5 participants
@bhazzard @stephenpdeos @linh2931 @enf-ci-bot @BenjaminGormanPMP