Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chainbase to include comparison of different signedness warning fix #1061

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Update chainbase to include comparison of different signedness warning fix #1061

merged 2 commits into from
Apr 20, 2023

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Apr 20, 2023 •
edited
Loading

Update chainbase to include AntelopeIO/chainbase#10 for fixing

/home/lh/work/leap-main/libraries/chainbase/include/chainbase/undo_index.hpp:524:23:    warning: comparison of integer expressions of different signedness: ‘uint64_t’ {aka ‘long unsigned int’} and ‘long int’ [-Wsign-compare]
  524 |          if( revision > std::numeric_limits<int64_t>::max() )
      |              ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

On Ubuntu 20.02, 26 of the remaining 27 warning instances are this warning (since it is included in a number of files).

Resolves #1053

@linh2931 linh2931 requested review from heifner and vladtr April 20, 2023 13:39
@linh2931 linh2931 merged commit da014a6 into main Apr 20, 2023
@linh2931 linh2931 deleted the update_chainbase branch April 20, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@vladtr vladtr vladtr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

different signedness comparison warnings
3 participants
@linh2931 @heifner @vladtr