-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speculative block repeatedly restarted when near block boundary #1432
Milestone
Comments
heifner
added a commit
that referenced
this issue
Aug 5, 2023
…, calculate_next_block_slot into block_timing_util
heifner
added a commit
that referenced
this issue
Aug 5, 2023
heifner
added a commit
that referenced
this issue
Aug 7, 2023
heifner
added a commit
that referenced
this issue
Aug 7, 2023
heifner
added a commit
that referenced
this issue
Aug 11, 2023
heifner
added a commit
that referenced
this issue
Aug 11, 2023
…spond to existing limit of 5secs on speculative execution on stale state.
heifner
added a commit
that referenced
this issue
Aug 11, 2023
heifner
added a commit
that referenced
this issue
Aug 14, 2023
heifner
added a commit
that referenced
this issue
Aug 15, 2023
Smarter block deadlines for speculative blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When speculatively executing trxs if a block is exhausted then it is now immediately restarted via: #1319. However, when starting a speculative block we set a block deadline according to pending block time minus producer time offset. This can create very small block times. A trx then can exceed that block time but not the configured trx max time resulting in a burst of abort_block/start_block calls.
Example scenario:
When not producing a block, the time limit of a block should be set to
fc::time_point::maximum()
since we want to allow as many speculative trxs as possible until another block is received. If the consensus max cpu or max net is exceeded then the block will be restarted as the trx/block will be considered exhausted.The text was updated successfully, but these errors were encountered: