-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify BLS host functions to fix failing tests on ARM builds #1701
Comments
To be clear, the For example,
|
This is needed for 5.0.0-rc3 because the discrepancy between the implementations (c++ and x86 implementations) has concerning implications. |
heifner
added a commit
that referenced
this issue
Nov 30, 2023
This was referenced Nov 30, 2023
heifner
added a commit
that referenced
this issue
Nov 30, 2023
[5.0] Update BLS host function doxygen comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Depends on AntelopeIO/bls12-381#17.
Some BLS tests, like the garbage tests in
test_fc
, seem to be failing on ARM builds. It's a little surprising because it appears the main bls test is passing. Could be something specific about the garbage tests + C impl. Needs more investigation.ARM is not supported, but failures there on newly added consensus code are probably worth understanding.
The text was updated successfully, but these errors were encountered: