Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify BLS host functions to fix failing tests on ARM builds #1701

Closed
spoonincode opened this issue Sep 30, 2023 · 2 comments · Fixed by #1882 or #1939
Closed

Modify BLS host functions to fix failing tests on ARM builds #1701

spoonincode opened this issue Sep 30, 2023 · 2 comments · Fixed by #1882 or #1939
Assignees
Labels
bug Something isn't working 👍 lgtm

Comments

@spoonincode
Copy link
Member

spoonincode commented Sep 30, 2023

Depends on AntelopeIO/bls12-381#17.

Some BLS tests, like the garbage tests in test_fc, seem to be failing on ARM builds. It's a little surprising because it appears the main bls test is passing. Could be something specific about the garbage tests + C impl. Needs more investigation.

ARM is not supported, but failures there on newly added consensus code are probably worth understanding.

@spoonincode
Copy link
Member Author

To be clear, the bls12-381 test completes successfully. It's only test_fc and bls_primitives_unit_test_eos-vm that fail (and I believe only the garbage tests)

For example,

/Users/spoon/leap/libraries/libfc/test/crypto/test_bls.cpp:146: error: in "bls/g1_add_garbage": check p.equal(p_res) == true has failed [false != true]
/Users/spoon/leap/libraries/libfc/test/crypto/test_bls.cpp:159: error: in "bls/g2_add_garbage": check p.equal(p_res) == true has failed [false != true]
/Users/spoon/leap/libraries/libfc/test/crypto/test_bls.cpp:173: error: in "bls/g1_mul_garbage": check p.equal(p_res) == true has failed [false != true]
/Users/spoon/leap/libraries/libfc/test/crypto/test_bls.cpp:187: error: in "bls/g2_mul_garbage": check p.equal(p_res) == true has failed [false != true]
/Users/spoon/leap/libraries/libfc/test/crypto/test_bls.cpp:201: error: in "bls/g1_exp_garbage": check p.equal(p_res) == true has failed [false != true]
/Users/spoon/leap/libraries/libfc/test/crypto/test_bls.cpp:215: error: in "bls/g2_exp_garbage": check p.equal(p_res) == true has failed [false != true]

@arhag arhag moved this from Todo to In Progress in Team Backlog Oct 24, 2023
@arhag arhag added this to the Leap v5.0.0-stable milestone Oct 24, 2023
@arhag arhag moved this from Todo to In Progress in EOS EVM Oct 24, 2023
@arhag arhag added the bug Something isn't working label Oct 24, 2023
@bhazzard
Copy link

This is needed for 5.0.0-rc3 because the discrepancy between the implementations (c++ and x86 implementations) has concerning implications.

@bhazzard bhazzard changed the title some BLS tests are failing on ARM builds Modify BLS host functions to fix failing tests on ARM builds Nov 7, 2023
@arhag arhag linked a pull request Nov 13, 2023 that will close this issue
@yarkinwho yarkinwho moved this from In Progress to Awaiting Review in EOS EVM Nov 16, 2023
heifner added a commit that referenced this issue Nov 30, 2023
[5.0] Update BLS host function doxygen comments
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Nov 30, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in EOS EVM Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
5 participants