-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2P: Save and retry unlinkable blocks #1045
Conversation
Will it be easy to add a unit or integration test for this? |
There already are integration tests that verify this works. My first commit actually failed: https://github.com/AntelopeIO/leap/actions/runs/4724092570 because I was using the wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, Kevin, looks great!
Keep a small cache of unlinkable blocks to retry. This is mainly to address the issue of blocks coming in on multiple connections and getting processed out of order. On an unlinkable block exception, store the block and retry it if its
previous
block is applied.Resolves #452