Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P: Save and retry unlinkable blocks #1045

Merged
merged 6 commits into from
Apr 18, 2023
Merged

P2P: Save and retry unlinkable blocks #1045

merged 6 commits into from
Apr 18, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Apr 17, 2023

Keep a small cache of unlinkable blocks to retry. This is mainly to address the issue of blocks coming in on multiple connections and getting processed out of order. On an unlinkable block exception, store the block and retry it if its previous block is applied.

Resolves #452

@heifner heifner requested review from greg7mdp and linh2931 April 17, 2023 19:04
@heifner heifner added the OCI Work exclusive to OCI team label Apr 17, 2023
@heifner heifner added this to the Leap v5.0.0-rc1 milestone Apr 17, 2023
@linh2931
Copy link
Member

Will it be easy to add a unit or integration test for this?

@heifner
Copy link
Member Author

heifner commented Apr 18, 2023

Will it be easy to add a unit or integration test for this?

There already are integration tests that verify this works. My first commit actually failed: https://github.com/AntelopeIO/leap/actions/runs/4724092570 because I was using the wrong id.

Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, Kevin, looks great!

@heifner heifner merged commit a1b1722 into main Apr 18, 2023
@heifner heifner deleted the GH-452-block-buffer branch April 18, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Propose block buffer design for P2P syncing processes
3 participants