Refactor libfc tests into one executable #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
reviewed
Apr 27, 2023
libraries/libfc/test/CMakeLists.txt
Outdated
| add_subdirectory( static_variant ) | ||
| add_subdirectory( variant ) | ||
| add_subdirectory( variant_estimated_size ) | ||
| file(GLOB UNIT_TESTS |
There was a problem hiding this comment.
Not a huge fan of file(GLOB) since it's easy to be confused why a new .cpp file isn't being compiled. But now that we're on cmake 3.12+ we can use CONFIGURE_DEPENDS which makes it less of a trap.
Also, I wonder about using GLOB_RECURSE here so we don't need to specify each sub directory?
There was a problem hiding this comment.
Thanks. Just listed them explicitly which seems to be the preferred way.
There was a problem hiding this comment.
I think it would have been interesting to try CONFIGURE_DEPENDS + GLOB_RECURSE and see how it goes. Up to you.
spoonincode
approved these changes
Apr 27, 2023
greg7mdp
approved these changes
Apr 27, 2023
greg7mdp
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of adding some new tests for #641, a bit of refactoring of
libfctests.Combine all tests into one executable. Combined they run in a fraction of a second.
Combining them seems in line with #586.