-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pinned build versions for boost and llvm-src #1118
Conversation
this can be updated to 1.71 now Line 108 in 2ad3148
and then this can be removed leap/libraries/chain/include/eosio/chain/types.hpp Lines 79 to 87 in 2ad3148
|
scripts/pinned_build.sh
Outdated
@@ -109,9 +109,8 @@ install_boost() { | |||
try wget -O "boost_${BOOST_VER//\./_}.tar.gz" "https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VER}/source/boost_${BOOST_VER//\./_}.tar.gz" | |||
try tar --transform="s:^boost_${BOOST_VER//\./_}:boost_${BOOST_VER//\./_}patched:" -xvzf "boost_${BOOST_VER//\./_}.tar.gz" -C "${DEP_DIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can get rid of the "patched" postfix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, did both of these!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove scripts/0001-beast-fix-moved-from-executor.patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove
scripts/0001-beast-fix-moved-from-executor.patch
Thanks Kevin, done.
@@ -105,7 +105,7 @@ set(Boost_USE_MULTITHREADED ON) | |||
set( Boost_USE_STATIC_LIBS ON CACHE STRING "ON or OFF" ) | |||
# Most boost deps get implictly picked up via fc, as just about everything links to fc. In addition we pick up | |||
# the pthread dependency through fc. | |||
find_package(Boost 1.70 REQUIRED COMPONENTS program_options unit_test_framework system) | |||
find_package(Boost 1.71 REQUIRED COMPONENTS program_options unit_test_framework system) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, Boost 1.71 does not work with C++20 at least for clang++16. Does this need to be 1.74 at least?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, when we enable c++20 we're going to need to do.. something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we'll have to change the boost minimum version when we enable c++20.
I personally would like us to use boost 1.82 always. Maybe add boost
as a submodule (I talked with Areg about it already).
I think we would benefit to use a common version of boost regardless of how (pinned vs unpinned) or on what system leap
is built on.
This would also allow us to use newer libraries such as boost::json
.
Should I update the find_package version for boost in submodules as well?
|
…build_dep_versions
@spoonincode are you OK with approving this PR now? |
I was going to finish running the tests before approving |
Sounds good, thanks Matt! |
Resolves #1120
boost:
1.70.0
->1.82.0
llvm src (for EOS VM oc):
7.1.0
->11.0.1
Removed compilation of boost::filesystem which is not used anymore.
Removed unneeded patch for boost.
Validated on ubuntu
20.04
and22.04
: