P2P Refactor connections management #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
requested changes
May 18, 2023
linh2931
reviewed
May 18, 2023
linh2931
reviewed
May 18, 2023
linh2931
reviewed
May 18, 2023
plugins/net_plugin/net_plugin.cpp
Outdated
| if( cptr != connections.end() ) { | ||
| auto cstart_it = cptr; | ||
| do { | ||
| // select the first one which is current and has lib above current and break out. |
There was a problem hiding this comment.
Why no indentation in this do-while body?
There was a problem hiding this comment.
Not sure how that happened. Fixed.
linh2931
requested changes
May 19, 2023
| } | ||
|
|
||
| void net_plugin::register_update_p2p_connection_metrics(std::function<void(net_plugin::p2p_connections_metrics)>&& fun){ | ||
| my->update_p2p_connection_metrics = std::move(fun); | ||
| // called from any thread |
There was a problem hiding this comment.
Add a comment here saying a lock is in another start_conn_timer.
plugins/net_plugin/net_plugin.cpp
Outdated
| continue; | ||
| } | ||
| } else { | ||
| --num_clients; ++num_rm; |
greg7mdp
requested changes
May 19, 2023
greg7mdp
requested changes
May 22, 2023
…nd for_each_block_connection to not short circuit
greg7mdp
approved these changes
May 22, 2023
linh2931
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor connections set into a
connections_managerclass.Simplify connections monitor timer implementation.
In preparation of work on #1072.