Avoid trying to kill a node twice to prevent orphaned processes. #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jun 6, 2023
oschwaldp-oci
approved these changes
Jun 6, 2023
|
Accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests terminate some nodes but not all. The
atexitroutine intended to be the final catchall for cleaning up a cluster would fail to terminate all nodes if it tried to terminate a node which had been shut down viainterruptAndVerifyExitStatusfirst. Tolerate terminated nodes and if the globalDebugflag is set, log double kills. (The log message should be converted to a customTRACElevel when the code is converted to the Pythonloggingmodule.)