remove FC_USE_PTHREAD_NAME_NP & pthread_getname_np() usage
#1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Jun 20, 2023
| } | ||
| #else | ||
| static int thread_count = 0; | ||
| thread_name = std::string( "thread-" ) + std::to_string( thread_count++ ); |
There was a problem hiding this comment.
On mac we used to always get the thread-n version here. Does this now provide the actual thread name on mac?
There was a problem hiding this comment.
yes; really for any platform the thread names should be logged identically now since get_thread_name() just pulls from the static thread_local std::string thread_name -- that is, no platform specific code is invoked for thread names for logging purposes.
But on macos & freebsd we've also gained the thread names being set at the platform level, and I've confirmed on macos they do show in the debugger.
heifner
approved these changes
Jun 20, 2023
linh2931
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the thread name stuff a bit to make it simpler (have gotten bitten here a few times lately such as #1283 and #1058)
set_os_thread_name()andset_thread_name()-- there is no reason setting the thread name shouldn't just set the OS thread name, having both of these (wasset_thread_name()even used?) is just confusingHAVE_PTHREAD_SETNAME_NPcheck; I think this was added at some point to resolve building on musl which didn't havepthread_getname_np()but while it does now,pthread_getname_np()-- just not necessary to use this instead of referring to the existingthread_local thread_name