[PH] Create workflow to test backward compatibility of performance harness #1356
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| name: "Build leap" | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| workflow_call: | ||
| outputs: | ||
| p: | ||
| description: "Discovered Build Platforms" | ||
| value: ${{ jobs.d.outputs.p }} | ||
|
|
||
| permissions: | ||
| packages: write | ||
|
There was a problem hiding this comment. I think this should just be permissions:
packages: write
contents: readSo I think as long as leap/.github/workflows/build.yaml Lines 34 to 38 in 4e19e36 Having packages: read in this location should cause all jobs in this workflow other then build-platform be read, where build-platform is write.
(btw your ph_backward_compatibility.yaml already does this) leap/.github/workflows/ph_backward_compatibility.yaml Lines 6 to 8 in 4e19e36 There was a problem hiding this comment. Good catch. Slipped past when I was changing the others. I've corrected that now. |
||
| contents: read | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| d: | ||
| name: Discover Platforms | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| missing-platforms: ${{steps.discover.outputs.missing-platforms}} | ||
| p: ${{steps.discover.outputs.platforms}} | ||
| steps: | ||
| - name: Discover Platforms | ||
| id: discover | ||
| uses: AntelopeIO/discover-platforms-action@v1 | ||
| with: | ||
| platform-file: .cicd/platforms.json | ||
| password: ${{secrets.GITHUB_TOKEN}} | ||
| package-name: builders | ||
|
|
||
| build-platforms: | ||
| name: Build Platforms | ||
| needs: d | ||
| if: needs.d.outputs.missing-platforms != '[]' | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| platform: ${{fromJSON(needs.d.outputs.missing-platforms)}} | ||
| runs-on: ["self-hosted", "enf-x86-beefy"] | ||
| permissions: | ||
| packages: write | ||
| contents: read | ||
| steps: | ||
| - name: Login to Container Registry | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{github.repository_owner}} | ||
| password: ${{secrets.GITHUB_TOKEN}} | ||
| - name: Build and push | ||
| uses: docker/build-push-action@v3 | ||
| with: | ||
| push: true | ||
| tags: ${{fromJSON(needs.d.outputs.p)[matrix.platform].image}} | ||
| file: ${{fromJSON(needs.d.outputs.p)[matrix.platform].dockerfile}} | ||
|
|
||
| Build: | ||
| needs: [d, build-platforms] | ||
| if: always() && needs.d.result == 'success' && (needs.build-platforms.result == 'success' || needs.build-platforms.result == 'skipped') | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| platform: [ubuntu20, ubuntu22] | ||
| runs-on: ["self-hosted", "enf-x86-beefy"] | ||
| container: ${{fromJSON(needs.d.outputs.p)[matrix.platform].image}} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| submodules: recursive | ||
| - name: Build | ||
| id: build | ||
| run: | | ||
| # https://github.com/actions/runner/issues/2033 | ||
| chown -R $(id -u):$(id -g) $PWD | ||
| cmake -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr -GNinja | ||
| cmake --build build | ||
| tar -pc --exclude "*.o" build | zstd --long -T0 -9 > build.tar.zst | ||
| - name: Upload builddir | ||
| uses: AntelopeIO/upload-artifact-large-chunks-action@v1 | ||
| with: | ||
| name: ${{matrix.platform}}-build | ||
| path: build.tar.zst | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this job (that uses the reusable workflow) doesn't have a name it seems to show up as simply
build-basein the GUI in various places. I'm a little surprises it doesn't inherit the callee workflow name. Maybe we could consider giving this a name (even justBuild) to show up nicer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with name
Run Build Workflow: