Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> main] Test: Fix ship test to wait on correct transaction #1391

Merged
merged 3 commits into from
Jul 11, 2023
Merged

[4.0 -> main] Test: Fix ship test to wait on correct transaction #1391

merged 3 commits into from
Jul 11, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 11, 2023

state_history_plugin test ship_streamer_test.py was not waiting on the correct transaction to be included in a block.

Merges release/4.0 into main including #1388

Resolves #1383

@heifner heifner requested review from greg7mdp and spoonincode July 11, 2023 18:09
@heifner heifner added the OCI Work exclusive to OCI team label Jul 11, 2023
@heifner heifner merged commit 08c2b81 into main Jul 11, 2023
@heifner heifner deleted the GH-1383-ship-test-main branch July 11, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Failure: ship_streamer_test
3 participants
@heifner @greg7mdp @spoonincode