.gitignore cleanup - mostly stop ignoring *.cmake files.
#1460
Conversation
| @@ -94,3 +91,5 @@ CMakeLists.txt.user | |||
|
|
|||
| node_modules | |||
| package-lock.json | |||
|
|
|||
| snapshots | |||
There was a problem hiding this comment.
when is this one a problem?
There was a problem hiding this comment.
Not sure where these come from, I just saw these show up in my "Untracked" files:
~/github/enf/leap gitignore_cleanup:main ⇡5 !1 ?14 ❯ ls snapshots plugins/snapshots
plugins/snapshots:
snapshot-000000062d3e86cb288ecdfd37e4ba5f313b97c04b3c8f47e010275c4a37fe62.bin
snapshots:
snapshot-000000062d3e86cb288ecdfd37e4ba5f313b97c04b3c8f47e010275c4a37fe62.bin snapshot-00000006c38bac7f934ac5cf688d8530bac0d112e0404548e391aef2b404bda2.bin
| @@ -7,23 +7,20 @@ | |||
| *.wast.hpp | |||
| *.dot | |||
| *.abi.hpp | |||
| *.cmake | |||
There was a problem hiding this comment.
I don't quite understand the removal of this one... won't it cause all the various cmake files in the build dir be flagged? Like CPackSourceConfig.cmake and CTestTestfile.cmake etc etc?
There was a problem hiding this comment.
We have this rule in .gitignore:
[Bb]uild*/*
which causes everything in my build dirs to be ignored.
There was a problem hiding this comment.
ah, true. but if the gitignore only supports build directories named build* or cmake-build-{release,debug}, then quite a bit of other cruft can likely be removed too
There was a problem hiding this comment.
I'm all for cleaning it up further. I think we should assume that the build dirs are already excluded, as this is normally the case
which file? |
.gitignore
Outdated
| *.ninja | ||
| \#* | ||
| \.#* | ||
| CMakeCache.txt | ||
| CMakeFiles | ||
| cmake_install.cmake | ||
| cmake-build-debug/ | ||
| cmake-build-release/ |
There was a problem hiding this comment.
Can we change these to cmake-build-*/ please. I have for example cmake-build-debug-clang11/.
There was a problem hiding this comment.
Makes sense... done!
*.cmakefiles!.cicd.cachedirectorysnapshotsdirectories