migrate to AntelopeIO's bls12-381 repo; minor additional bls12-381 usage tweaks #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Aug 2, 2023
greg7mdp
approved these changes
Aug 3, 2023
| return return_code::success; | ||
| } | ||
|
|
||
| int32_t interface::bls_g1_mul(span<const char> point, span<const char> scalar, span<char> result) const | ||
| { | ||
| if(point.size() != 144 || scalar.size() != 32 || result.size() != 144) | ||
| return return_code::failure; | ||
| std::optional<bls12_381::g1> a = bls12_381::g1::fromJacobianBytesLE({reinterpret_cast<const uint8_t*>(point.data()), 144}, false, true); | ||
| std::optional<bls12_381::g1> a = bls12_381::g1::fromJacobianBytesLE(std::span<uint8_t, 144>((uint8_t*)point.data(), 144), false, true); |
There was a problem hiding this comment.
Maybe not lose the const and pass std::span<const uint8_t, 144>. Same in other locations.
greg7mdp
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work to complete the tasks in #1413. For the most part this PR is just switching the bls12-381 library to the AntelopeIO fork plus any fixups that come from that as any other submodule update. Will include