-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Clean up of bls_private_key, bls_public_key and bls_signature, … #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d string prefix, added base58 to_string + parsing code for bls_private_key + unit test, removed old unit test
heifner
requested changes
Aug 21, 2023
Added checksum + wif import / export based on fc::crypto::private_key |
heifner
requested changes
Aug 22, 2023
greg7mdp
reviewed
Aug 22, 2023
Why do we recompute the secret key every time we sign?
|
…_t, 4> to remove the need to recompute the private key everytime we sign
I changed the storage type from vector<uint8_t> to array<uint64_t, 4>, which allows us to avoid recomputing the key every time we sign |
greg7mdp
requested changes
Aug 25, 2023
heifner
reviewed
Aug 25, 2023
greg7mdp
requested changes
Aug 25, 2023
…eIO/leap into bls_cleanup_test_changes
…or and base58 constructor
greg7mdp
requested changes
Aug 25, 2023
greg7mdp
requested changes
Aug 26, 2023
…, minor style corrections
greg7mdp
requested changes
Aug 27, 2023
…ct equivalence test
…ct equivalence test
Co-authored-by: Gregory Popovitch <[email protected]>
Co-authored-by: Gregory Popovitch <[email protected]>
greg7mdp
approved these changes
Aug 27, 2023
@heifner can we merge this one? |
heifner
approved these changes
Aug 28, 2023
@systemzax please push the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…removed string prefix, added base58 to_string + parsing code for bls_private_key + unit test, removed old unit test