Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0 -> main] HTTP: Check for connection_reset #1665

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 21, 2023

When running performance tests on read-only transaction execution, the node generated many errors of read_header: Connection reset by peer and didn't make additional progress.

Boost beast http session checks for http::error::end_of_stream || asio::error::connection_reset in on_read and executes do_eof() to shutdown the connection. on_read_header was checking for http::error::end_of_stream but not asio::error::connection_reset. This PR changes on_read_header to also check for asio::error::connection_reset.

Merges branch release/4.0 into main including #1663

Resolves #1661

@heifner heifner added the OCI Work exclusive to OCI team label Sep 21, 2023
@heifner heifner merged commit 6a4d3e3 into main Sep 21, 2023
@heifner heifner deleted the GH-1661-conn-reset-main branch September 21, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Under heavy load http read_header 'Connection reset by peer'
4 participants