Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PH: Disable p2p trx execution on validation and api nodes #1709

Merged
merged 1 commit into from
Oct 4, 2023
Merged

PH: Disable p2p trx execution on validation and api nodes #1709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/PerformanceHarness/performance_test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ def __post_init__(self):

def configureValidationNodes():
validationNodeSpecificNodeosStr = ""
validationNodeSpecificNodeosStr += '--p2p-accept-transactions false '
Copy link
Member

@linh2931 linh2931 Oct 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove the statement above and do validationNodeSpecificNodeosStr = '--p2p-accept-transactions false ' directly?

Same comment for below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to make the changes. I am approving it now so that it can make to 5.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a fine change. Previously all additions to validationNodeSpecificNodeosStr were conditional so it was needed to initialize the variable. Looks like down below apiNodeSpecificNodeosStr could've been initialized directly with the first option instead of to a blank string first.

if "v2" in self.nodeosVers:
validationNodeSpecificNodeosStr += '--plugin eosio::history_api_plugin --filter-on "*" '
else:
Expand All @@ -137,6 +138,7 @@ def configureValidationNodes():

def configureApiNodes():
apiNodeSpecificNodeosStr = ""
apiNodeSpecificNodeosStr += "--p2p-accept-transactions false "
apiNodeSpecificNodeosStr += "--plugin eosio::chain_api_plugin "
apiNodeSpecificNodeosStr += "--plugin eosio::net_api_plugin "
if "v4" in self.nodeosVers:
Expand Down