Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] Test: Pass in exitOnError so that a retry is allowed #1739

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[5.0] Test: Pass in exitOnError so that a retry is allowed #1739

merged 1 commit into from
Oct 10, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 9, 2023

#1728 added a retry for publishContract (set contract), however, the retry never executed because the waitForTransactionInBlock would exit on error. Wired in passing exitOnError so that a retry could actually run.

Resolves #1501

@heifner heifner requested a review from oschwaldp-oci October 9, 2023 16:53
@heifner heifner added the OCI Work exclusive to OCI team label Oct 9, 2023
@heifner heifner requested a review from greg7mdp October 9, 2023 18:33
@heifner heifner merged commit ac6c70f into release/5.0 Oct 10, 2023
@heifner heifner deleted the GH-1501-retry-retry-5.0 branch October 10, 2023 13:00
@heifner heifner mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@oschwaldp-oci oschwaldp-oci oschwaldp-oci approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heifner @greg7mdp @oschwaldp-oci