[5.0] fix "All Required Tests Passed" CI Branch Protection #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leap repo has a branch protection rule that "All Required Tests Passed" is required to pass. At least I think that's what it's suppose to mean. Now I'm not sure because, mind bogglingly, when that test is skipped (because a dependent job failed) it doesn't block the PR! Consider this example where,
Expected behavior in this case is to not have the "white" merge button (it should be red for admins; and simply not allowed for non-admins).
So... restore this job back to how it was previously via
if: always()and status checks on the dependent jobs.Sending to 5.0 because this branch protection rule is important.