[5.0 -> main] Undo the temporary switch to mapped mode when loading a snapshot in mapped_private mode #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `mapped_private` mode.
[5.0] Undo the temporary switch to `mapped` mode when loading a snapshot in `mapped_private` mode.
heifner
approved these changes
Oct 26, 2023
linh2931
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1764
The reason I initially added this
revert_to_private_mode()(so we'd load a snapshot inmappedmode, and revert tomapped_privatemode after the snapshot is loaded), was that I hoped that we would only touch a few pages in normalmapped_privatefunctioning.The snapshot loading seemed a bad case where all state db pages containing data would be touched.
However, even in normal syncing, most of the pages are dirty after a few minutes, so the remap optimization is not worth it I believe.