[3.2] Fix non-working cleos set code and set abi commands #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
approved these changes
Nov 14, 2023
programs/cleos/main.cpp
Outdated
| wasmPath = (cpath / wasmPath).generic_string(); | ||
| // contractPath (set by contract-dir argument) is only applicable | ||
| // to "set contract" command | ||
| if(is_set_contract) { |
There was a problem hiding this comment.
you might be able to use !contractPath.empty() instead of a new variable?
There was a problem hiding this comment.
Thanks. My solution emphasizes the intention of contractPath only applicable to set contract. Your solution is simpler and covers emptiness check for any conditions. Changed to use yours.
heifner
approved these changes
Nov 14, 2023
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleos
set codeandset abihave not worked sincerelease/3.2. The root cause is the common codeset_code_callbackforset contractandset codeassumescontract-dirargument which is only applicable toset contract; and the common codeset_code_callbackforset abiandset codeassumescontract-dirargument too.This PR fixes the problem.
The fix has been tested manually. CI tests will be added to
release/5.0to minimize changes to 3.2.Resolves #1868.