Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Remove block_state_legacy access #2013

Merged
merged 13 commits into from
Dec 21, 2023
Merged

IF: Remove block_state_legacy access #2013

merged 13 commits into from
Dec 21, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 20, 2023 •
edited
Loading

  • Removed most uses of controller::head_block_state()
    • Renamed controller::head_block_state() to controller::head_block_state_legacy() for remaning uses in tests
    • Added controller::had_block_timestamp()
  • Removed /v1/chain/get_block_header_state
  • Removed controller::fetch_block_state_by_number()
  • Removed controller::fetch_block_state_by_id()

@greg7mdp
Copy link
Contributor

Changes look great, thanks Kevin. I just noticed that there are some test failures though.

@arhag arhag linked an issue Dec 20, 2023 that may be closed by this pull request
IF: Unification: Create new block_header_state and block_state #1941
Closed
@heifner heifner changed the title IF: Remove controller::head_block_state() IF: Remove block_state_legacy access Dec 21, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Dec 21, 2023
@heifner heifner merged commit 1bda5c1 into gh_1941 Dec 21, 2023
@heifner heifner deleted the GH-1941-head-block-state branch December 21, 2023 19:49
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Changes to support Instant Finality refactoring controller, plugins, and tests to support new and legacy block_header_state and block_state
Note:end

@greg7mdp
Copy link
Contributor

greg7mdp commented Dec 28, 2023 •
edited
Loading

Hi @heifner, because the libtester tests were failing in the hotstuff_integration branch, we missed that the removal of head_block_state causes a failure in libtester, see here. Do we just need to rename to head_block_state_legacy()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Unification: Create new block_header_state and block_state
3 participants
@heifner @greg7mdp @ericpassmore