IF: Fix double confirming test failure #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not found in existing unittests. Most of these are likely redundant, but change_inflation, votepay_share_invariant, and votepay_transition2 triggered a producer_double-confirming error no other tests found.
linh2931
approved these changes
Jan 8, 2024
| //idump((confirm_count[i])); | ||
| if( result.confirm_count[i] == 0 ) | ||
| { | ||
| --result.confirm_count[i]; |
There was a problem hiding this comment.
Just copied over the 5.0 impl, including spaces
greg7mdp
approved these changes
Jan 8, 2024
Comment on lines
+7
to
+16
| #warning Add last_proposed_finalizer_policy_generation to snapshot_block_header_state_v3, see header file TODO | ||
|
|
||
| namespace detail { | ||
| uint32_t get_next_next_round_block_num( block_timestamp_type t, uint32_t block_num ) { | ||
| auto index = t.slot % config::producer_repetitions; // current index in current round | ||
| // (increment to the end of this round ) + next round | ||
| return block_num + (config::producer_repetitions - index) + config::producer_repetitions; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I moved this in a new file in my PR so as not to duplicate, however we can checkin as-is and I'll remove in my PR.
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference contracts: https://github.com/AntelopeIO/reference-contracts eosio system tests were failing do a double confirmation error. Port of tests from reference contracts to provide same coverage in leap.
Revert unneeded changes in
block_header_state_legacysince it no longer contains instant finality logic.Add
controller::head_active_producers()needed bytester.