-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pinned Build on Ubuntu 22.04 #833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with reverting this until a fix is decided on, so we can get the builds operational again asap
…_7-11" Co-authored-by: Matt Witherspoon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evaluate #834 and abandon this if its a solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base branch is broken and the 4.0 release is blocked. The correct thing to do is to revert the breaking change. If someone wants to try to re-implement the feature we were attempting to introduce, anyone is welcome to post up another PR. The PR you suggested is a draft, it is not ready for peer review and we do not even know if it would fix the problem if it were. Reverting breaking changes is always the right thing to do because we want the base branch to be in a working state at any given point in time. |
fwiw I changed #834 to a draft after Scott made his comment -- after I realized it didn't work in all cases because of how the script works. It does otherwise fix the issue with a fresh depdir |
From issue 735, this reverts pull request 799 (Search for LLVM versions 7-11, prefering latest version) to fix the pinned build on Ubuntu 22.04. There are no other changes in this PR besides the revert.
Pull request 799 introduced code that attempts to automagically find the correct version of LLVM for the Leap build on systems that have multiple versions of LLVM installed and available. This code only runs when
cmake
is version 3.19 or newer. Ubuntu 22.04 ships with CMake version 3.22.1, following the new code path, whereas Ubuntu 20.04 ships with version 3.16.3 that does not follow the new code path. This explains why the pinned build only fails on Ubuntu 22.04.I have verified the Ubuntu 22.04 pinned build works on this branch.
Credit to @spoonincode for identifying the cause of the bug.
See Also
Pull Request 832 - Rollinstall_deps.sh
intopinned_build.sh
libcurl4-openssl-dev
README.md
Formatting