[4.0] Execute read only safe tasks on read-only thread pool #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adline to allow it.
…_highest_read_only()
…ly trxs during start block.
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 29, 2023
greg7mdp
reviewed
Mar 30, 2023
Since repost_exhausted_transactions is called in start_block, check should_interrupt_start_block in while loop.
greg7mdp
reviewed
Mar 30, 2023
This was referenced Mar 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves read-only safe operations to also execute on the read-only thread pool along with read-only transactions during the
read-only-read-window-time-uswindow.Note read and write windows are interrupted when new blocks are received.
--read-only-threadsnow defaults to 3 on non-producer configurednodeosthat enable theeosio::chain_api_plugin.Block relay nodes or canary nodes should consider
--read-only-threads=0. Sinceeosio::chain_api_pluginmay be enabled so/v1/chain/get_infois available. If other http request and push_* operations ofeosio::chain_api_pluginare not used there is no benefit to enablingread-only-threads. Ifread-only-threadsare enabled, but not utilized, there is a very small overhead of switching back and forth between the read/write windows.See: #837 (comment)
Moves
/v1/net/*calls to http thread pool, off main app thread, since they are thread-safe.Builds on #776.
Resolves #810