Merge pull request #95 from AntelopeIO/remove_instant_finality_extens…

…ion_cpp Remove almost empty instant_finality_extension.cpp
AntelopeIO · Apr 29, 2024 · 3f0c7d5 · 3f0c7d5
2 parents 81f5666 + 83b11ca
commit 3f0c7d5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 15 deletions.
diff --git a/libraries/chain/CMakeLists.txt b/libraries/chain/CMakeLists.txt
@@ -81,7 +81,6 @@ set(CHAIN_WEBASSEMBLY_SOURCES
 
 set(CHAIN_FINALITY_SOURCES
         finality/finalizer.cpp
-        finality/instant_finality_extension.cpp
         finality/quorum_certificate.cpp
         finality/finality_core.cpp
 )

diff --git a/libraries/chain/finality/instant_finality_extension.cpp b/libraries/chain/finality/instant_finality_extension.cpp
diff --git a/libraries/chain/include/eosio/chain/finality/instant_finality_extension.hpp b/libraries/chain/include/eosio/chain/finality/instant_finality_extension.hpp
@@ -19,7 +19,11 @@ struct instant_finality_extension : fc::reflect_init {
       new_proposer_policy(std::move(new_proposer_policy))
    {}
 
-   void reflector_init();
+   void reflector_init() const {
+      static_assert( fc::raw::has_feature_reflector_init_on_unpacked_reflected_types,
+                     "instant_finality_extension expects FC to support reflector_init" );
+      static_assert( extension_id() == 2, "instant_finality_extension extension id must be 2" );
+   }
 
    qc_claim_t                         qc_claim;
    std::optional<finalizer_policy>    new_finalizer_policy;